feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955

sagely1 · 2025-01-04T00:00:32Z

Description

This is a collection of fixes found during manual testing (AG-1604)
This also incorporates changes from Q4 2024 (AG-1605)

Fixes

Fixed GCT loading animation was not displaying when loading the page. New CSS was written to support the new standalone component.
Download chart functionality was not working with FireFox and the latest download-dom-image-more package. It is a known issue so the width and height are now being explicitly passed to maintain cross-compatibility.
Due to the removal of Bootstrap, the Resources tab in Gene Details was not displaying the resource cards properly so new CSS was written to achieve a similar effect. The original code has element inconsistently aligned either left or center so this has been updated to left justified.
SHA in footer was displaying the full SHA so this was updated to show the shortened SHA.

sagely1 · 2025-01-05T01:10:52Z

apps/agora/data/.env.example

@@ -7,6 +7,6 @@ DB_HOST="agora-mongo" # must match mongo service name

 # specifies data release manifest and team images folder
 DATA_FILE="syn13363290"
-DATA_VERSION="68"
+DATA_VERSION="71"


updating data_version to match current Agora production version

sagely1 · 2025-01-05T01:13:18Z

libs/agora/genes/src/lib/components/gene-resources/gene-resources.component.html

-          <div class="row tab-row last-row">
-            <div id="target-enabling-resources-card1" class="col-md-3 col-sm-8 col-8 header-title">


col-sm* and col-md* are part of the bootstrap dependency that was removed for migration to the monorepo

hallieswan · 2025-01-06T17:51:44Z

libs/agora/shared/src/lib/loading-overlay/loading-overlay.component.html

+<pre>
+  isActive: {{ isActive }} 
+  isGlobal: {{ isGlobal }}
+</pre>
+


Should this be included here?

hallieswan · 2025-01-06T20:59:21Z

libs/agora/ui/src/lib/components/footer/footer.component.ts

  }

  ngOnInit(): void {
    this.dataVersion$ = this.dataVersionService.getDataversion();
-    this.sha$ = this.gitHubService.getCommitSHA('agora/v0.0.2');
+    this.sha$ = this.gitHubService.getCommitSHA(this.tag);


What do you think about creating a ticket to use appVersion and adding a related TODO here? Just thinking it would be great to capture your thoughts from our chat earlier today about tracking the app version in one place once the tag format is finalized!

hallieswan · 2025-01-06T21:00:04Z

libs/agora/shared/src/lib/loading-overlay/loading-overlay.component.ts

+    console.log('global', this.isGlobal);
    if (this.isGlobal) {
      this.helperService.loadingChange.subscribe(() => {
        this.isActive = this.helperService.getLoading();
+        console.log('active', this.isActive);


Could the log statements be removed?

Suggested change

console.log('global', this.isGlobal);

if (this.isGlobal) {

this.helperService.loadingChange.subscribe(() => {

this.isActive = this.helperService.getLoading();

console.log('active', this.isActive);

if (this.isGlobal) {

this.helperService.loadingChange.subscribe(() => {

this.isActive = this.helperService.getLoading();

hallieswan · 2025-01-06T21:13:33Z

libs/agora/genes/tsconfig.lib.json

@@ -8,5 +8,5 @@
    "types": []
  },
  "exclude": ["src/test-setup.ts", "**/*.spec.ts", "**/*.test.ts", "jest.config.ts"],
-  "include": ["**/*.ts"]
+  "include": ["**/*.ts", "src/lib/components/gene-similar/gene-similar.component.spec.ts"]


Just curious, why does gene-similar need to be included here, but the other subcomponents don't need to be included (e.g. gene-table)?

hallieswan · 2025-01-06T21:23:28Z

libs/agora/genes/tsconfig.spec.json

+    "**/*.spec.ts",
+    "**/*.d.ts",
+    "jest.config.ts",
+    "src/lib/components/gene-similar/gene-similar.component.spec.ts"


Would the gene-similar test already be picked up by "**/*.spec.ts", so this line may not be needed?

tschaffter · 2025-01-06T21:41:07Z

libs/agora/genes/src/lib/components/gene-hero/gene-hero.component.html

          <div class="gene-hero-aliases">
            <h4 class="gene-hero-aliases-heading">Also known as</h4>
-            @if (getEnsemblUrl() !== '') {
-              <p>
+            @if (getEnsemblUrl()) {


Suggested change

@if (getEnsemblUrl()) {

@if (getEnsemblUrl(); as ensembleUrl) {

Reference the result of the function and use it in the if block, instead of calling the getter twice.

tschaffter · 2025-01-06T21:48:54Z

libs/agora/services/src/lib/github.service.ts

-    //   Authorization: `Bearer ${this.token}`,
-    // });
-
-    // return this.http.get<any[]>(this.apiUrl, { headers }).pipe(
    return this.http.get<any[]>(this.apiUrl).pipe(


Specify the type of the output instead of using any[]. Either using an interface or this.http.get<Array<{ name: string; commit: { sha: string } }>>.

tschaffter · 2025-01-06T21:51:58Z

tsconfig.base.json

@@ -25,6 +25,7 @@
        "libs/agora/gene-comparison-tool/src/index.ts"
      ],
      "@sagebionetworks/agora/gene-details": ["libs/agora/genes/src/index.ts"],
+      "@sagebionetworks/agora/gene-similar": ["libs/agora/genes/src/index.ts"],


This line may be referencing the incorrect index file (currently the same as @sagebionetworks/agora/gene-details).

Same comment actually for @sagebionetworks/agora/gene-details, which references the same index file as @sagebionetworks/agora/genes.

fix loading animation for gct, cards in details page, shortened sha

55d1e22

sagely1 requested a deployment to sonar January 4, 2025 00:00 — with GitHub Actions Waiting

sagely1 changed the title ~~fix loading animation for gct, cards in details page, shortened sha~~ feat(agora): agora fixes (AG-1604) Jan 4, 2025

sagely1 changed the title ~~feat(agora): agora fixes (AG-1604)~~ feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) Jan 4, 2025

code cleanup

69d2e2a

sagely1 requested a deployment to sonar January 4, 2025 00:22 — with GitHub Actions Waiting

syncing changes from Q4 2024 and code cleanup

980166f

sagely1 requested a deployment to sonar January 5, 2025 01:08 — with GitHub Actions Waiting

sagely1 requested a review from hallieswan January 5, 2025 01:09

sagely1 commented Jan 5, 2025

View reviewed changes

sagely1 added 2 commits January 5, 2025 02:16

fixing warnings

5eaf8ab

moving github tag logic into config

9bb4a68

sagely1 marked this pull request as ready for review January 6, 2025 17:04

sagely1 requested review from a team and tschaffter as code owners January 6, 2025 17:04

sagely1 requested a deployment to sonar January 6, 2025 20:15 — with GitHub Actions Waiting

hallieswan reviewed Jan 6, 2025

View reviewed changes

tschaffter reviewed Jan 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955

feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955

sagely1 commented Jan 4, 2025 •

edited

Loading

sagely1 Jan 5, 2025

sagely1 Jan 5, 2025

hallieswan Jan 6, 2025

hallieswan Jan 6, 2025

hallieswan Jan 6, 2025

hallieswan Jan 6, 2025

hallieswan Jan 6, 2025

tschaffter Jan 6, 2025

tschaffter Jan 6, 2025

tschaffter Jan 6, 2025 •

edited

Loading

tschaffter Jan 6, 2025

tschaffter Jan 6, 2025

		<div class="row tab-row last-row">
		<div id="target-enabling-resources-card1" class="col-md-3 col-sm-8 col-8 header-title">

	@if (getEnsemblUrl()) {
	@if (getEnsemblUrl(); as ensembleUrl) {

feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955

Are you sure you want to change the base?

feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955

Conversation

sagely1 commented Jan 4, 2025 • edited Loading

Description

Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tschaffter Jan 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagely1 commented Jan 4, 2025 •

edited

Loading

tschaffter Jan 6, 2025 •

edited

Loading