-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agora): agora fixes (AG-1604) and Q4 2024 changes (AG-1605) #2955
base: main
Are you sure you want to change the base?
Changes from all commits
55d1e22
69d2e2a
980166f
5eaf8ab
9bb4a68
0a70efa
67de677
df594cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,6 @@ | |
"appVersion": "4.0.0", | ||
"csrApiUrl": "http://localhost:3333/v1", | ||
"ssrApiUrl": "http://agora-api:3333/v1", | ||
"rollbarToken": "e788198867474855a996485580b08d03" | ||
"rollbarToken": "e788198867474855a996485580b08d03", | ||
"tagName": "agora/v0.0.2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in the future, this could be potentially removed if we are ok with looking for the tagname in this particular format. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ import { ExperimentalValidation } from './experimentalValidation'; | |
import { EnsemblInfo } from './ensemblInfo'; | ||
import { RnaDifferentialExpression } from './rnaDifferentialExpression'; | ||
import { BioDomains } from './bioDomains'; | ||
import { GeneNetworkLinks } from './geneNetworkLinks'; | ||
import { TargetNomination } from './targetNomination'; | ||
import { NeuropathologicCorrelation } from './neuropathologicCorrelation'; | ||
import { SimilarGenesNetwork } from './similarGenesNetwork'; | ||
|
@@ -31,6 +32,7 @@ export interface Gene { | |
summary: string; | ||
hgnc_symbol: string; | ||
alias: Array<string>; | ||
uniprotkb_accessions?: Array<string>; | ||
is_igap: boolean; | ||
is_eqtl: boolean; | ||
is_any_rna_changed_in_ad_brain: boolean; | ||
|
@@ -39,7 +41,7 @@ export interface Gene { | |
protein_brain_change_studied: boolean; | ||
target_nominations: Array<TargetNomination> | null; | ||
median_expression: Array<MedianExpression>; | ||
druggability: Array<Druggability>; | ||
druggability: Druggability; | ||
total_nominations: number | null; | ||
is_adi?: boolean; | ||
is_tep?: boolean; | ||
|
@@ -52,12 +54,12 @@ export interface Gene { | |
overall_scores?: OverallScores; | ||
neuropathologic_correlations?: Array<NeuropathologicCorrelation> | null; | ||
experimental_validation?: Array<ExperimentalValidation> | null; | ||
links?: { [key: string]: object } | null; | ||
links?: { [key: string]: GeneNetworkLinks } | null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is now strongly typed unlike in the original codebase. |
||
similar_genes_network?: SimilarGenesNetwork; | ||
ab_modality_display_value?: string | null; | ||
safety_rating_display_value?: string | null; | ||
sm_druggability_display_value?: string | null; | ||
pharos_class_display_value?: string | null; | ||
pharos_class_display_value?: Array<string> | null; | ||
is_any_rna_changed_in_ad_brain_display_value?: string | null; | ||
is_any_protein_changed_in_ad_brain_display_value?: string | null; | ||
nominated_target_display_value?: boolean | null; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* Agora REST API | ||
* No description provided (generated by Openapi Generator https://github.com/openapitools/openapi-generator) | ||
* | ||
* The version of the OpenAPI document: 1.0.0 | ||
* | ||
* | ||
* NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech). | ||
* https://openapi-generator.tech | ||
* Do not edit the class manually. | ||
*/ | ||
|
||
/** | ||
* Gene Network Links | ||
*/ | ||
export interface GeneNetworkLinks { | ||
/** | ||
* Ensembl gene ID for gene A | ||
*/ | ||
geneA_ensembl_gene_id: string; | ||
/** | ||
* Ensembl gene ID for gene B | ||
*/ | ||
geneB_ensembl_gene_id: string; | ||
/** | ||
* External gene name for gene A | ||
*/ | ||
geneA_external_gene_name: string; | ||
/** | ||
* External gene name for gene B | ||
*/ | ||
geneB_external_gene_name: string; | ||
/** | ||
* Associated brain region | ||
*/ | ||
brainRegion: string; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
type: object | ||
description: Gene Network Links | ||
properties: | ||
geneA_ensembl_gene_id: | ||
type: string | ||
description: 'Ensembl gene ID for gene A' | ||
geneB_ensembl_gene_id: | ||
type: string | ||
description: 'Ensembl gene ID for gene B' | ||
geneA_external_gene_name: | ||
type: string | ||
description: 'External gene name for gene A' | ||
geneB_external_gene_name: | ||
type: string | ||
description: 'External gene name for gene B' | ||
brainRegion: | ||
type: string | ||
description: 'Associated brain region' | ||
required: | ||
- geneA_ensembl_gene_id | ||
- geneB_ensembl_gene_id | ||
- geneA_external_gene_name | ||
- geneB_external_gene_name | ||
- brainRegion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future, it may be good to create consistency as returning an object with an items property could be replaced with just returning the array as it is here. biodomains and a few other gene api calls would need to be updated.