Completion for Active Record .where queries #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
This may also help: Shopify/ruby-lsp#2913 |
|
Planning on finishing and hopefully shipping this PR during hackdays next week! |
ChallaHalla
changed the title
ChallaHalla
force-pushed
the
369-completion-for-activerecord-queries
branch
2 times, most recently
from
0b09971 to
896ba66
Compare
ChallaHalla
force-pushed
the
369-completion-for-activerecord-queries
branch
3 times, most recently
from
7077b8b to
44cbede
Compare
ChallaHalla
force-pushed
the
369-completion-for-activerecord-queries
branch
from
44cbede to
def281a
Compare
vinistock
reviewed
Dec 12, 2024
vinistock
reviewed
Dec 13, 2024
Comment on lines
+48
to
+51
| if arguments | ||
| indexed_call_node_args = index_call_node_args(arguments: arguments) | ||
| return if indexed_call_node_args.values.any? { |v| v == node } | ||
| end |
There was a problem hiding this comment.
What is this early return checking for exactly? Is it that we're not processing arguments inside a nested call inside of the where?
There was a problem hiding this comment.
This early return is meant to prevent suggestions when the user is typing in an argument value within a .where in general. E.g when the user is typing User.where(id: creat they shouldn't receive a column name suggestion for created_at.
There was a problem hiding this comment.
Covered in this test case here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #369
Adding ActiveRecord
.wherecompletion suggestions.I've chosen to only provide suggestions once the user begins typing the name of the column to filter by. This is slightly different than the spec in the ticket. I don't think the call_node_enter listener can be used if suggestions are to be provided before the user begins typing a column name.
Happy to investigate this further! But I think this can be added as a follow up in another PR since the approach for when to begin suggesting seems like it should be different.
Here are some videos of how this looks!
vscode-demo.mov
neo-vim-demo.mov