Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow for 'Local Flow' scenario #78

Conversation

ivysochyn
Copy link
Contributor

Update CI workflow for 'Local Flow' scenario

This PR updates the local flow build process and the CI workflow to improve compatibility with the latest bazel-orfs changes.

This PR modifies the following:

  • .github/scripts/build_local_target.sh

    • Modified flow to operate on 'in-place' stages (e.g. do-floorplan instead of floorplan)
    • Modified the script to handle additional sub-stages in the synthesis (synth) stage, including do-yosys-canonicalize and do-yosys
    • Updated logging to provide more detailed and specific output for each build and run stage
  • .github/workflows/ci.yml

    • Updated the Docker image used in the local flow to openroad/orfs:v3.0-1114-g46acc762 to align with the one used by the project. Resolves the incompatible database schema revision error
    • Removed an outdated conditional statement in the CI workflow that was no longer necessary

Refactors script to the updated Local flow

Signed-off-by: Illia Vysochyn <[email protected]>
@ivysochyn
Copy link
Contributor Author

@oharboe Here's the fix for the CI as discussed earlier today.

Copy link
Collaborator

@oharboe oharboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

.github/workflows/ci.yml Show resolved Hide resolved
@ivysochyn ivysochyn force-pushed the ivysochyn/preserve-local-flow-artifacts branch from 1e8b93d to 576a88f Compare August 9, 2024 12:52
Copy link
Collaborator

@oharboe oharboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

@@ -73,7 +73,8 @@ jobs:
name: Local flow - test targets
runs-on: ubuntu-22.04
container:
image: openroad/orfs:v3.0-1022-g69767b6a@sha256:adc74e5343a7638919f747eb74cbc67b5b71b18d9012608fef912ccee534c458
# NOTE: Ensure this is kept in sync with MODULE.bazel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can we make this an error if it is different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to extract those values from MODULE.bazel instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do so in a followup PR. Merging for now so that pull requests that come in are tested.

@oharboe oharboe merged commit cf3c01b into The-OpenROAD-Project:main Aug 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants