-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI workflow for 'Local Flow' scenario #78
Update CI workflow for 'Local Flow' scenario #78
Conversation
Refactors script to the updated Local flow Signed-off-by: Illia Vysochyn <[email protected]>
@oharboe Here's the fix for the CI as discussed earlier today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
Signed-off-by: Illia Vysochyn <[email protected]>
1e8b93d
to
576a88f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
@@ -73,7 +73,8 @@ jobs: | |||
name: Local flow - test targets | |||
runs-on: ubuntu-22.04 | |||
container: | |||
image: openroad/orfs:v3.0-1022-g69767b6a@sha256:adc74e5343a7638919f747eb74cbc67b5b71b18d9012608fef912ccee534c458 | |||
# NOTE: Ensure this is kept in sync with MODULE.bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, can we make this an error if it is different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to extract those values from MODULE.bazel
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do so in a followup PR. Merging for now so that pull requests that come in are tested.
Update CI workflow for 'Local Flow' scenario
This PR updates the local flow build process and the CI workflow to improve compatibility with the latest
bazel-orfs
changes.This PR modifies the following:
.github/scripts/build_local_target.sh
do-floorplan
instead offloorplan
)synth
) stage, includingdo-yosys-canonicalize
anddo-yosys
.github/workflows/ci.yml
openroad/orfs:v3.0-1114-g46acc762
to align with the one used by the project. Resolves the incompatible database schema revision error