Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow for 'Local Flow' scenario #78

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Update CI workflow for 'Local Flow' scenario #78

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a429983
scripts: build_local_target.sh: Refactor local flow
ivysochyn Aug 9, 2024
576a88f
CI: Update local flow Docker image revision
ivysochyn Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ jobs:
name: Local flow - test targets
runs-on: ubuntu-22.04
container:
image: openroad/orfs:v3.0-1022-g69767b6a@sha256:adc74e5343a7638919f747eb74cbc67b5b71b18d9012608fef912ccee534c458
# NOTE: Ensure this is kept in sync with MODULE.bazel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can we make this an error if it is different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to extract those values from MODULE.bazel instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do so in a followup PR. Merging for now so that pull requests that come in are tested.

image: openroad/orfs:v3.0-1114-g46acc762@sha256:ae4df23391c26bcc48a506f8e0d0da73742d1b6cb3b1dc02f4d5ea71170195b5
ivysochyn marked this conversation as resolved.
Show resolved Hide resolved
defaults:
run:
shell: bash
Expand Down Expand Up @@ -149,7 +150,6 @@ jobs:
STAGES: synth floorplan place
run: .github/scripts/build_local_target.sh
- name: Open target
if: matrix.STAGE_TARGET == 'L1MetadataArray_generate_abstract'
run: |
for stage in "floorplan" "place"; do
echo | build/make open_${stage}
Expand Down
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ git_override(
#)

orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
# NOTE: Ensure this is kept in sync with CI
orfs.default(
image = "openroad/orfs:v3.0-1114-g46acc762",
sha256 = "ae4df23391c26bcc48a506f8e0d0da73742d1b6cb3b1dc02f4d5ea71170195b5",
Expand Down