-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(modules): minify code without losing readability #303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 576 579 +3
=========================================
+ Hits 576 579 +3 ☔ View full report in Codecov by Sentry. |
I like yours better. Maybe add a comment for each short variable that we define. The comment will be stripped by the bundler. |
This PR will trigger no release when merged. |
I have added a comment to the non obvious ones. For the rest, it is pretty clear what the variables mean. |
🎉 This PR is included in version 2.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Decrease total size (less than 16kB) without losing readability.