Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(modules): minify code without losing readability #303

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Oct 16, 2024

Decrease total size (less than 16kB) without losing readability.

Copy link

aem-code-sync bot commented Oct 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@kptdobe kptdobe requested a review from trieloff October 16, 2024 13:47
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c8e9388) to head (fd77abb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #303   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          576       579    +3     
=========================================
+ Hits           576       579    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trieloff
Copy link
Contributor

I like yours better. Maybe add a comment for each short variable that we define. The comment will be stripped by the bundler.

@adobe-bot
Copy link
Collaborator

This PR will trigger no release when merged.

@kptdobe
Copy link
Contributor Author

kptdobe commented Oct 16, 2024

I have added a comment to the non obvious ones. For the rest, it is pretty clear what the variables mean.

@kptdobe kptdobe merged commit 2a893c8 into main Oct 16, 2024
7 of 8 checks passed
@kptdobe kptdobe deleted the minify2 branch October 16, 2024 14:23
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 2.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants