-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give release archive workflows more time #170
Conversation
Well I tried to craft a test for this, but I've never used |
Ok, this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution and nice work with the predicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ouillie Are you able to run the e2e tests locally? It looks like the test [snapshot] error email for incorrect strip prefix in multi module repo
now times out due to the delay. We'll want a way to set a shorter delay for these tests.
I would be fine with just setting an env var during testing and checking for it in the release archive code. |
The e2e test fail for me even on the upstream main branch, so I just ignored them on my branch. Is there some setup I'm missing? I'm assuming you guys have some credentials or something that don't get distributed publicly. |
Just cuz I can't run it locally doesn't mean I can't try to fix it though :) |
Thanks @kormide. Do you know when this will be available in production? I'm going to wait to kick off my next release until I know it'll work. |
I already deployed it so it's ready for your next release! |
Addresses #140.