-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the beet
executable and update shebangs
#5303
Conversation
Apparently, this script isn't actually used for anything; the build system will automatically generate a script like this when installing `beets`. See <beetbox#4604>.
While Python 2 is long dead, and a 'bin/env python' shebang is probably perfectly fine, this is just a bit safer. See <beetbox#4604>.
I'm using this as a quick testing ground for #5305, hence the strange rebase. I'll re-adjust it once the checks complete. |
f80e461
to
8b3890b
Compare
Restored, ready for review / merge. |
Hmm, does this impact calling beets on the command with |
In a venv, I ran #!<path/to/my/venv>/bin/python
import sys
from beets.ui import main
if __name__ == '__main__':
sys.exit(main()) So as long as Poetry is being used to build |
Wonderful, should be fine to remove then. |
For context: The script that is actually being installed is generated by poetry via the |
Great, wasn't entirely sure and I thought it best to double check! Don't want to suddenly be unable to use beet as a command |
Yeah, absolutely! Honestly, I should've investigated how the actual |
Description
This is a very simple PR, just removing the (apparently unused)
beet
executable from the repository and substitutingbin/env python
forbin/python3
where possible.Fixes #4604.
To Do
Documentation.Tests.