-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changelog reminder workflow #5305
Conversation
I was expecting it to remind me to update the changelog on this PR too 🕵🏼 🤨 |
I'm going to try rebasing #5303 on top of this to trigger the changelog action. |
Testing for <beetbox#5305>.
@snejus, is it possible that it's using the version of the workflow that's on the |
Not sure, I think there's only one way to test it 🤷🏼♂️ at least now we know it shouldn't break! |
How bizarre. This is why testing GH actions are such a pita. They run in very strange ways. If you look at the checks, it hasn't been attempted. Maybe there's a restriction on running jobs that are being updated? |
It might still be running the version on master, rather than the one on the PR? |
Yeah, maybe we should just try merging this PR and seeing if it helps. I can't think of a better option, which sucks. |
GitHub actions and CI are amazing and useful but not easy to test and honestly, half of the time the only way TO test it is to push to production and just see what breaks. When I was writing the release workflow, I pushed to MY repo, and did a bunch of breaking changes, and then just reset it to upstream. And it still didn't find everything. |
I think it's happier now: https://github.com/beetbox/beets/actions/runs/9525145560/job/26258903712 |
Wonderful |
Quote the breaking glob as noted by @bal-e.