Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog reminder workflow #5305

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

snejus
Copy link
Member

@snejus snejus commented Jun 14, 2024

Quote the breaking glob as noted by @bal-e.

@snejus snejus self-assigned this Jun 14, 2024
@snejus snejus mentioned this pull request Jun 14, 2024
@snejus
Copy link
Member Author

snejus commented Jun 14, 2024

I was expecting it to remind me to update the changelog on this PR too 🕵🏼 🤨

@snejus snejus requested a review from Serene-Arc June 14, 2024 15:13
@bal-e
Copy link
Member

bal-e commented Jun 14, 2024

I'm going to try rebasing #5303 on top of this to trigger the changelog action.

bal-e pushed a commit to bal-e/beets that referenced this pull request Jun 14, 2024
@bal-e
Copy link
Member

bal-e commented Jun 14, 2024

@snejus, is it possible that it's using the version of the workflow that's on the master branch?

@snejus
Copy link
Member Author

snejus commented Jun 14, 2024

Not sure, I think there's only one way to test it 🤷🏼‍♂️ at least now we know it shouldn't break!

@Serene-Arc
Copy link
Contributor

How bizarre. This is why testing GH actions are such a pita. They run in very strange ways. If you look at the checks, it hasn't been attempted. Maybe there's a restriction on running jobs that are being updated?

@Serene-Arc
Copy link
Contributor

It might still be running the version on master, rather than the one on the PR?

@bal-e
Copy link
Member

bal-e commented Jun 15, 2024

Yeah, maybe we should just try merging this PR and seeing if it helps. I can't think of a better option, which sucks.

@Serene-Arc
Copy link
Contributor

GitHub actions and CI are amazing and useful but not easy to test and honestly, half of the time the only way TO test it is to push to production and just see what breaks. When I was writing the release workflow, I pushed to MY repo, and did a bunch of breaking changes, and then just reset it to upstream. And it still didn't find everything.

@Serene-Arc Serene-Arc merged commit 54a8ef7 into master Jun 15, 2024
18 checks passed
@snejus snejus deleted the fix-changelog-reminder-workflow branch June 15, 2024 03:32
@snejus
Copy link
Member Author

snejus commented Jun 15, 2024

I think it's happier now: https://github.com/beetbox/beets/actions/runs/9525145560/job/26258903712

@Serene-Arc
Copy link
Contributor

Wonderful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants