Added the output instance_class #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gowiem
requested changes
Sep 25, 2024
Gowiem
requested changes
Sep 25, 2024
outputs.tf
Outdated
|
|
||
| output "instance_class" { | ||
| description = "The instance calss used by the DocumentDB Cluster. For more details, see https://docs.aws.amazon.com/documentdb/latest/developerguide/db-instance-classes.html#db-instance-class-specs" | ||
| value = distinct([for instance in aws_docdb_cluster_instance.default : instance.instance_class])[0] |
There was a problem hiding this comment.
@Faris96Hub how is this different from var.instance_class? Or is not different and you're using the default of that value, so you need it as an output? If the latter... can we just output var.instance_class instead of adding this looping logic?
There was a problem hiding this comment.
Im not using the default but using var.instance_class would be an option too, to avoid the loop. Ill change it
|
@Faris96Hub if we have input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Added the output instance_classwhy
Needed for monitoring reasons. Enables you to set the threshold of the CloudWatch alarm for FreeableMemory to a percentage value instead of Bytes. Because if you know the instance type, you know the RAM of it and you can set the threshold of the alarm to for example 70% of that. Unfortunately there is no data ressource to get the instance_class from otherwise (it gives just general information about available instance_classes)references
Data Ressource: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/docdb_orderable_db_instance#:~:text=X%2DRay-,Data%20Source,-%3A%20aws_docdb_orderable_db_instance
Freeable Memory: https://docs.aws.amazon.com/documentdb/latest/developerguide/cloud_watch.html#cloud_watch-metrics_list:~:text=one%2Dminute%20period.-,FreeableMemory,-The%20amount%20of
Instance_classes: https://docs.aws.amazon.com/documentdb/latest/developerguide/db-instance-classes.html#db-instance-class-specs