-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the output instance_class #111
Open
Faris96Hub
wants to merge
10
commits into
cloudposse:main
Choose a base branch
from
Faris96Hub:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ec9fce9
fix: added output cluster_members for resource aws_docdb_cluster
Faris96Hub d602b7b
fix: added flatten()
Faris96Hub f440ea7
Merge branch 'main' into main
Faris96Hub c0026e9
format
kevcube 5e8fcaa
feature: added instance_class as an output
Faris96Hub 240ec49
Merge remote-tracking branch 'origin/main'
Faris96Hub fd9ebec
Merge branch 'cloudposse:main' into main
Faris96Hub 462fa7b
chore: adds final newline
Gowiem 06c0eb0
fix: used the variable instance _class as the output to avoid the loop
Faris96Hub 1e1de9c
Merge remote-tracking branch 'origin/main'
Faris96Hub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Faris96Hub how is this different from
var.instance_class
? Or is not different and you're using the default of that value, so you need it as an output? If the latter... can we just outputvar.instance_class
instead of adding this looping logic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not using the default but using var.instance_class would be an option too, to avoid the loop. Ill change it