Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] +- Change appearing for a PR #3619

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jan 2, 2025

BEFORE

Screenshot 2025-01-02 at 12 28 14 PM

AFTER

Screenshot 2025-01-02 at 12 27 37 PM

This PR closes codecov/engineering-team#3044

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Jan 2, 2025

Bundle Report

Changes will decrease total bundle size by 6.14MB (-33.73%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.0MB 5 bytes (0.0%) ⬆️
gazebo-staging-system-esm 6.06MB 5 bytes (0.0%) ⬆️
gazebo-staging-array-push (removed) 6.14MB (-100.0%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (0e9f64a) to head (b8fe095).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3619   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14556           
  Branches     4147     4147           
=======================================
  Hits        14409    14409           
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/TotalsNumber/TotalsNumber.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...b8fe095. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3619   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14556           
  Branches     4147     4140    -7     
=======================================
  Hits        14409    14409           
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/TotalsNumber/TotalsNumber.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...b8fe095. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (0e9f64a) to head (b8fe095).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3619   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14556           
  Branches     4140     4140           
=======================================
  Hits        14409    14409           
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/TotalsNumber/TotalsNumber.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...b8fe095. Read the comment docs.

Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will decrease total bundle size by 6.14MB (-33.73%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 5 bytes (0.0%) ⬆️
gazebo-production-system-esm 6.06MB 5 bytes (0.0%) ⬆️
gazebo-production-array-push (removed) 6.14MB (-100.0%) ⬇️

Copy link
Contributor

sentry-autofix bot commented Jan 2, 2025

Sentry has generated a new PR with unit tests for this PR. View the new PR(#3620) to review the changes.

@sentry-autofix sentry-autofix bot mentioned this pull request Jan 2, 2025
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 2, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
000d07a Thu, 02 Jan 2025 17:35:43 GMT Expired Expired
b8fe095 Thu, 02 Jan 2025 17:51:59 GMT Expired Expired
b8fe095 Thu, 02 Jan 2025 17:52:10 GMT Expired Expired
b8fe095 Thu, 02 Jan 2025 17:55:51 GMT Cloud Enterprise

Co-authored-by: sentry-autofix[bot] <157164994+sentry-autofix[bot]@users.noreply.github.com>
Co-authored-by: Rohit Vinnakota <[email protected]>
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (0e9f64a) to head (b8fe095).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3619   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14556           
  Branches     4140     4147    +7     
=======================================
  Hits        14409    14409           
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
src/ui/TotalsNumber/TotalsNumber.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f64a...b8fe095. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review January 2, 2025 17:52
@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit ecdafdb Jan 2, 2025
62 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/plus-minus-fix branch January 2, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+- Change appearing for a PR
3 participants