[1/1][eas-cli] generate eas-update-metadata.json on publish #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinlanj
requested review from
EvanBacon,
byCedric,
wschurman,
szdziedzic and
khamilowicz
as code owners
|
/changelog-entry new-feature patch metadata.json with eas info on publish |
|
✅ Thank you for adding the changelog entry! |
|
Size Change: +249 B (0%) Total Size: 55.5 MB
|
wschurman
reviewed
Dec 19, 2023
There was a problem hiding this comment.
What do you think about putting this in a separate file? Something like eas-update-metadata.json or eas-update-info.json?
I worry that putting it in the same file could cause nondeterministic issues for other tooling that depends on metadata.json being just the original.
quinlanj
force-pushed
the
@quin/sentry
branch
from
7112b84 to
b643853
Compare
|
@wschurman i've amended the PR to generate |
quinlanj
changed the title
wschurman
approved these changes
Dec 19, 2023
szdziedzic
reviewed
Dec 19, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When we publish an update, a
metadata.jsonfile gets generated in thedistfolder. This PR patches themetadata.jsonwith someeasmetadata.motivation
It would be nice to have this for sentry-expo integration. While it is possible for users to specify the
jsonflag for the update command to output the same information, it will be nicer if we can tell people to just runeas updateand then run another script that will read from themetadata.jsonfileTest Plan
manually tested