fixup: always stop current pmtud timer when ack received

expressvpn · Oct 18, 2023 · 331dc8e · 331dc8e
1 parent 68e2738
commit 331dc8e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/he/pmtud.c b/src/he/pmtud.c
@@ -82,6 +82,11 @@ he_return_code_t he_internal_pmtud_handle_probe_ack(he_conn_t *conn, uint16_t pr
     return HE_SUCCESS;
   }
 
+  // Stop the timer
+  if(conn->pmtud_time_cb) {
+    conn->pmtud_time_cb(conn, 0, conn->data);
+  }
+
   // Reset the pending probe id
   conn->pmtud_probe_pending_id = 0;
 

diff --git a/test/support/test_defs.h b/test/support/test_defs.h
@@ -87,7 +87,9 @@ he_return_code_t pop_network_config_cb(he_conn_t *conn, he_network_config_ipv4_t
 }
 
 he_return_code_t pmtud_time_cb(he_conn_t *conn, int timeout, void *context) {
-  call_counter++;
+  if(timeout > 0) {
+    call_counter++;
+  }
   return HE_SUCCESS;
 }