Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: re-enable remote model tests #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: re-enable remote model tests #1021

wants to merge 1 commit into from

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from a team as code owners September 25, 2024 23:48
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 25, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 25, 2024
@GarrettWu GarrettWu enabled auto-merge (squash) September 25, 2024 23:52
@GarrettWu GarrettWu assigned GarrettWu and unassigned Genesis929 Sep 25, 2024
@GarrettWu GarrettWu disabled auto-merge September 26, 2024 01:24
@GarrettWu GarrettWu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2024
@GarrettWu
Copy link
Contributor Author

BQML rolled back the feature, so the tests are passing. While there are still issues to fix. b/353775058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Genesis929 Genesis929 Genesis929 approved these changes

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GarrettWu @Genesis929