Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable remote model tests #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Open

test: re-enable remote model tests #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,7 @@ def cover(session):
"--show-missing",
"--include=tests/unit/*",
"--include=tests/system/small/*",
# TODO(b/353775058) resume coverage to 100 when the issue is fixed.
"--fail-under=99",
"--fail-under=100",
)

session.run("coverage", "erase")
Expand Down
1 change: 0 additions & 1 deletion tests/system/small/ml/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@ def test_model_detect_anomalies(
)


@pytest.mark.skip("b/353775058 BQML internal error")
def test_remote_model_predict(
bqml_linear_remote_model: core.BqmlModel, new_penguins_df
):
Expand Down
2 changes: 0 additions & 2 deletions tests/system/small/ml/test_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@
# limitations under the License.

import pandas as pd
import pytest

from bigframes.ml import remote


@pytest.mark.skip("b/353775058 BQML internal error")
def test_remote_linear_vertex_model_predict(
linear_remote_vertex_model: remote.VertexAIModel, new_penguins_df
):
Expand Down