Improve markdown heading highlights #12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Jan 5, 2025
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Jan 6, 2025
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the markdown highlights to apply the
@markup.heading.<n>(e.g.@markup.heading.3) captures to the entire heading - not just the text content, specifically including the marker (##part of## ABC). I have tested this and can confirm that if themarkup.heading.markerkey is set in the theme configuration, that applies to the headers. If it isn't set, the@markup.heading.<n>capture styles apply.