Fix Typedarray.slice fastpath when the content type is matching #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes jerryscript-project#4888. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
rerobika
force-pushed
the
fix_issue_4888
branch
from
a9c2a27 to
0c78251
Compare
dbatyai
requested changes
Dec 10, 2021
| { | ||
| memcpy (dst_buffer_p, src_buffer_p, count << info_p->shift); | ||
| } | ||
| else if (count >= new_typedarray_info.offset) |
There was a problem hiding this comment.
What if count is less than the target offset? I don't think this condition is correct.
var buf = new ArrayBuffer(10);
var a1 = new Int8Array(buf, 0, 5);
a1.fill(1);
a1.constructor = {
[Symbol.species]: function (len) {
return new Int8Array(buf, 5, 5);
}
};
var a2 = a1.slice(2,4);
res = new Int8Array(buf, 0, 10);
Also, I don't think checking the offset is the right way, we need to check whether the two typedarrays use the same arraybuffer instead, and only then fall back to copying element-by-element.
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 25, 2024
This patch fixes jerryscript-project#4888. The implementation is based on PR jerryscript-project#4898, only resolved the conflicts and applied requested changes. Co-authored-by: Robert Fancsik [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
|
I close this since the original author abandoned the PR. #5177 is the continuation of this fix. |
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 26, 2024
This patch fixes jerryscript-project#4888. The implementation is based on PR jerryscript-project#4898, only resolved the conflicts and applied requested changes. Co-authored-by: Robert Fancsik [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 26, 2024
This patch fixes jerryscript-project#4888. The implementation is based on PR jerryscript-project#4898, only resolved the conflicts and applied requested changes. Co-authored-by: Robert Fancsik [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
LaszloLango
pushed a commit
that referenced
this pull request
Nov 26, 2024
This patch fixes #4888. The implementation is based on PR #4898, only resolved the conflicts and applied requested changes. Co-authored-by: Robert Fancsik [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #4888.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]