Skip to content

Bump dashmap from 5.5.2 to 6.0.0 #173

Bump dashmap from 5.5.2 to 6.0.0

Bump dashmap from 5.5.2 to 6.0.0 #173

GitHub Actions / clippy succeeded Jun 18, 2024 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 270 in src/bin/flamegraph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
   --> src/bin/flamegraph.rs:270:13
    |
270 |             options.title = defaults::CHART_TITLE.to_owned();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `defaults::CHART_TITLE.clone_into(&mut options.title)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 242 in src/bin/flamegraph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> src/bin/flamegraph.rs:242:9
    |
242 |         options.title = self.title.clone();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `options.title.clone_from(&self.title)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `#[warn(clippy::assigning_clones)]` on by default

Check warning on line 620 in src/flamegraph/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant guard

warning: redundant guard
   --> src/flamegraph/mod.rs:620:32
    |
620 |                 Some(delta) if delta == 0 => write!(
    |                                ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
    = note: `#[warn(clippy::redundant_guards)]` on by default
help: try
    |
620 -                 Some(delta) if delta == 0 => write!(
620 +                 Some(0) => write!(
    |

Check warning on line 395 in src/flamegraph/color/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/flamegraph/color/mod.rs:395:36
    |
395 |         let hash3 = (hash as f64 / std::u64::MAX as f64) as f32;
    |                                    ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
    |
395 |         let hash3 = (hash as f64 / u64::MAX as f64) as f32;
    |                                    ~~~~~~~~

Check warning on line 392 in src/flamegraph/color/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/flamegraph/color/mod.rs:392:36
    |
392 |         let hash2 = (hash as f64 / std::u64::MAX as f64) as f32;
    |                                    ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
    |
392 |         let hash2 = (hash as f64 / u64::MAX as f64) as f32;
    |                                    ~~~~~~~~

Check warning on line 387 in src/flamegraph/color/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/flamegraph/color/mod.rs:387:36
    |
387 |         let hash1 = (hash as f64 / std::u64::MAX as f64) as f32;
    |                                    ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
    |
387 |         let hash1 = (hash as f64 / u64::MAX as f64) as f32;
    |                                    ~~~~~~~~

Check warning on line 104 in src/flamegraph/color/palette_map.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

file opened with `create`, but `truncate` behavior not defined

warning: file opened with `create`, but `truncate` behavior not defined
   --> src/flamegraph/color/palette_map.rs:104:55
    |
104 |         let mut file = OpenOptions::new().write(true).create(true).open(path)?;
    |                                                       ^^^^^^^^^^^^- help: add: `.truncate(true)`
    |
    = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
    = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
    = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
    = note: `#[warn(clippy::suspicious_open_options)]` on by default