Skip to content

Bump dashmap from 5.5.2 to 6.0.0 #173

Bump dashmap from 5.5.2 to 6.0.0

Bump dashmap from 5.5.2 to 6.0.0 #173

GitHub Actions / clippy succeeded Jun 18, 2024 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.80.0-beta.3 (105fc5ccc 2024-06-14)
  • cargo 1.80.0-beta.3 (34a6a87d8 2024-06-04)
  • clippy 0.1.80 (105fc5c 2024-06-14)

Annotations

Check warning on line 919 in src/flamegraph/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/flamegraph/mod.rs:919:21
    |
919 |     svg.write_event(&cache_rect)
    |                     ^^^^^^^^^^^ help: change this to: `cache_rect`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 769 in src/flamegraph/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/flamegraph/mod.rs:769:25
    |
769 |         svg.write_event(&cache_g)?;
    |                         ^^^^^^^^ help: change this to: `cache_g`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 762 in src/flamegraph/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/flamegraph/mod.rs:762:29
    |
762 |             svg.write_event(&cache_g)?;
    |                             ^^^^^^^^ help: change this to: `cache_g`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 758 in src/flamegraph/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/flamegraph/mod.rs:758:29
    |
758 |             svg.write_event(&cache_a)?;
    |                             ^^^^^^^^ help: change this to: `cache_a`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 620 in src/flamegraph/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant guard

warning: redundant guard
   --> src/flamegraph/mod.rs:620:32
    |
620 |                 Some(delta) if delta == 0 => write!(
    |                                ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
    = note: `#[warn(clippy::redundant_guards)]` on by default
help: try
    |
620 -                 Some(delta) if delta == 0 => write!(
620 +                 Some(0) => write!(
    |

Check warning on line 395 in src/flamegraph/color/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/flamegraph/color/mod.rs:395:36
    |
395 |         let hash3 = (hash as f64 / std::u64::MAX as f64) as f32;
    |                                    ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
    |
395 |         let hash3 = (hash as f64 / u64::MAX as f64) as f32;
    |                                    ~~~~~~~~

Check warning on line 392 in src/flamegraph/color/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/flamegraph/color/mod.rs:392:36
    |
392 |         let hash2 = (hash as f64 / std::u64::MAX as f64) as f32;
    |                                    ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
    |
392 |         let hash2 = (hash as f64 / u64::MAX as f64) as f32;
    |                                    ~~~~~~~~

Check warning on line 387 in src/flamegraph/color/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/flamegraph/color/mod.rs:387:36
    |
387 |         let hash1 = (hash as f64 / std::u64::MAX as f64) as f32;
    |                                    ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
    |
387 |         let hash1 = (hash as f64 / u64::MAX as f64) as f32;
    |                                    ~~~~~~~~

Check warning on line 104 in src/flamegraph/color/palette_map.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

file opened with `create`, but `truncate` behavior not defined

warning: file opened with `create`, but `truncate` behavior not defined
   --> src/flamegraph/color/palette_map.rs:104:55
    |
104 |         let mut file = OpenOptions::new().write(true).create(true).open(path)?;
    |                                                       ^^^^^^^^^^^^- help: add: `.truncate(true)`
    |
    = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
    = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
    = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
    = note: `#[warn(clippy::suspicious_open_options)]` on by default

Check warning on line 151 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `nightly`

warning: unexpected `cfg` condition value: `nightly`
   --> src/lib.rs:151:17
    |
151 | #[cfg(all(test, feature = "nightly"))]
    |                 ^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `clap`, `cli`, `crossbeam-channel`, `crossbeam-utils`, `dashmap`, `default`, `env_logger`, `indexmap`, `multithreaded`, and `nameattr`
    = help: consider adding `nightly` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

Check warning on line 148 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `nightly`

warning: unexpected `cfg` condition value: `nightly`
   --> src/lib.rs:148:23
    |
148 | #![cfg_attr(all(test, feature = "nightly"), feature(test))]
    |                       ^^^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `clap`, `cli`, `crossbeam-channel`, `crossbeam-utils`, `dashmap`, `default`, `env_logger`, `indexmap`, `multithreaded`, and `nameattr`
    = help: consider adding `nightly` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `#[warn(unexpected_cfgs)]` on by default