Add/controls template esnext #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
intelijens
commented
Jun 13, 2020
| * | ||
| * @see https://www.npmjs.com/package/@wordpress/scripts#using-css | ||
| */ | ||
| import './style.scss'; |
There was a problem hiding this comment.
@fabiankaegy can we discuss this import during our meet up, I noticed some odd behavior when I left it included, causing my block to NOT show up in the editor, even when plugin is activated.
|
After activating the plugin on a site I get this error: |
|
Thank you for pointing out that error @brezocordero, I will try to recreate and perform additional testing. Also, thank you for the recommendation of suggesting completion of the initial documentation, i.e., description, how has this been tested, screenshots. |
…moved unneeded import js; add back in the scss to the template block folder; prevent missing css error; all of this will likely change with gutenberg and create block update; adjusted background colors for editor view and client view to easily distinguish block is active
|
|
Merge in master from wordpress repo, via jsa pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add in new template for Create Block package, using Gutenberg Examples - 04 Controls ESNext
Example block written with ESNext standard and JSX support for GUI Controls– build step required.
How has this been tested?
cd gutenbergnpx wp-create-block -t controls-esnextScreenshots
Step 8
Step 9
Step 10
Types of changes
Add - new example template
Checklist:
Commit Log: