Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]bump gateway_api_version to v1.2.0 #11636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KubeKyrie
Copy link
Contributor

@KubeKyrie KubeKyrie commented Oct 15, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support Gateway API upgrade to v1.2.0
See https://gateway-api.sigs.k8s.io/guides/?h=crds#v12-upgrade-notes
Which issue(s) this PR fixes:

Fixes #11630

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bump Gateway API to v1.2.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KubeKyrie
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @KubeKyrie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-kind flake
/kind feature

@@ -1,4 +1,4 @@
---
gateway_api_enabled: false
gateway_api_version: v1.1.0
gateway_api_version: v1.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code at the beginning, only change this is useless, in order to support offline installation, I finally did not use to this variable (PR #11376), I hope that the version can be differentiated by folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding.

  1. I do not understand how the support of offline installation affects this variable.
  2. And how should I do to upgrade gateway_api. Should v1.1.0 be retained after updating?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can refer #11376.
My imagination is that you could put the original Gateway API CRDs in the v1.1.0 folder, and you create a separate v1.2.0 folder for the new version, and then you could use the gateway_api_version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, difference gateway-api version by folder is not very good for scaling. We can't add a directory for every version because the list will be very long after later versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Gateway API release cycle is not very frequent, reserve 3 patch version I think it's appropriate.
If you have a better idea, you can suggest in a comment.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/flake Categorizes issue or PR as related to a flaky test. labels Oct 15, 2024
@yankay
Copy link
Member

yankay commented Oct 15, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2024
@KubeKyrie KubeKyrie changed the title bump gateway_api_version to v1.2.0 [WIP]bump gateway_api_version to v1.2.0 Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Gateway API upgrade to v1.2.1
4 participants