Use debug stdout callback in ci rather than manual debug #11793
Merged
+112
−251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to 2ba28a3 (Revert "Wait for available API token in a new namespace (kubernetes-sigs#7045)", 2024-10-25). While checking for the serviceaccount token is not effective, there is still a race when creating a Pod directly, because the ServiceAccount itself might not be created yet. More details at kubernetes/kubernetes#66689. This cause very frequent flakes in our CI with spurious failures. Use a Deployment instead ; it will takes cares of creating the Pods and retrying ; it also let us use kubectl rollout status instead of manually checking for the pods.
There is no pods with hostNetwork deployed in this test, and therefore the tasks are skipped / empty output (checked in CI).
k8s-ci-robot
added
release-note-none
|
/ok-to-test |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
ok-to-test
VannTen
force-pushed
the
cleanup/ci_testcases_better_callback
branch
2 times, most recently
from
a0dcc09 to
ab53a29
Compare
|
/label tide/merge-method-merge |
k8s-ci-robot
added
the
tide/merge-method-merge
VannTen
force-pushed
the
cleanup/ci_testcases_better_callback
branch
4 times, most recently
from
3f16e58 to
b44a731
Compare
This display in a readable (by humans) way the result of most tasks, and should be way more readable that what we have now, which is frequently a bunch of unreadable json. + some small fixes (using delegated_to instead of when <control_plane_host>)
We don't test Flatcar at all in CI, thus remove special handling for it.
VannTen
force-pushed
the
cleanup/ci_testcases_better_callback
branch
from
b44a731 to
86a949d
Compare
yankay
reviewed
Dec 17, 2024
| set_fact: | ||
| bin_dir: "/usr/local/bin" | ||
| when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"] | ||
|
|
There was a problem hiding this comment.
I think the removal of the Flatcar test case is acceptable, although it's somewhat regrettable. It would be great if we could add the Flatcar test case in the future.
There was a problem hiding this comment.
Yeah I don't mind adding a test ; but in the meantime, we should not adjust for things we don't actually test.
This isn't hard to revert later if needed.
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm It's worth mentioning that I am also a fan of the yaml stdout callback plugin which is usually quite human readable, but perhaps debug makes more sense for CI. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
CI: Use the debug stdout callback instead of manual debug
This display in a readable (by humans) way the result of most tasks, and
should be way more readable that what we have now, which is frequently a
bunch of unreadable json.
+ some small fixes
This is on top of #11792 so the other one should be merged first
/hold
Does this PR introduce a user-facing change?: