Fixes sorting order of trash items #4845
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjester
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
We should add a followup to address the existing reverse usage. I believe we do want it reversed, which means the most recently modified are first, but I think this will address the major issue and is an improvement in the current behavior. We'll just have to address the fetch ordering in the followup to re-implement the reverse for a future release
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr fixes a pagination issue in the trashed items where newly shown resources are displayed on top of the page making it seems like nothing has happened on clicking the "Show more" button.
Screen.Recording.2024-12-03.at.14.57.58.mov
References
Fixes #4837
Reviewer guidance