Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Polish VS Code DX #44865

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 27, 2024

It looks like this was due for a refresh.

.vscode/settings.json

As I understand it, a baseline version of this is supposed to be stored on git (then people can add their settings to further customize it). Proof:

I have tried to only have the least opinionated settings.

.editorconfig

Now that we have .mdx and .tsx files, this is due for a refresh. We also started to stop relying on trim_trailing_whitespace for markdown line break (but instead use \). So we can apply this everywhere. See #34762.

I also got annoyed with the UX on https://mui.com/toolpad/

SCR-20241227-miqr

.gitignore

Remove .vscode, per VS Code codebase, they don't do this.

.vscode/extensions.json

I suspect that those mui/base-ui#1151 got introduced because the right VS Code extension wasn't installed.

.vscode/launch.json

This is for

SCR-20241227-mjuu

I'm not aware anyone uses it. We would need to clean up it.


Same PR open in all the repositories ⬇️

@mui-bot
Copy link

mui-bot commented Dec 27, 2024

Netlify deploy preview

https://deploy-preview-44865--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ee267e8

@oliviertassinari oliviertassinari added the dx Related to developers' experience label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Related to developers' experience enhancement This is not a bug, nor a new feature scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants