chore: fix the CI benchmarks posting and also exit gracefully if not even relevant #6966
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark results
|
ndhoule
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
post-package-sizeaction isn't a required step, but it is annoying that it fails when it doesn't need to fail, and can make engineers spend too much time in slack threads trying to figure out what is going on. This will hopefully prevent that although long slack threads are fun and maybe we shouldn't avoid them?Oh also this action hasn't even been working for 7 months because we upgraded to
actions/upload-artifact@v4which ignores hidden files by default whereas v3 didn't, and all our.delta.*files are hidden. lolA picture of a cute animal (not mandatory, but encouraged)
