Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: support TypedArray and DataView in StatementSync #56385

Merged
merged 1 commit into from
Jan 5, 2025
Merged

sqlite: support TypedArray and DataView in StatementSync #56385

merged 1 commit into from
Jan 5, 2025
+83 −6

Conversation

himself65
Copy link
Member

Fixes: #56384

@himself65 himself65 requested a review from cjihrig December 28, 2024 20:04
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Dec 28, 2024
@himself65 himself65 force-pushed the himself65/20241228/fix branch from 79ca6ef to aa1218f Compare December 28, 2024 20:39
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (91c6b8a) to head (46c1763).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56385   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         657      657           
  Lines      190689   190761   +72     
  Branches    36597    36611   +14     
=======================================
+ Hits       168826   168892   +66     
- Misses      15030    15038    +8     
+ Partials     6833     6831    -2
Files with missing lines Coverage Δ
src/node_sqlite.cc 82.34% <100.00%> (+0.54%) ⬆️

... and 53 files with indirect coverage changes

jasnell
jasnell reviewed Dec 29, 2024
View reviewed changes
src/node_sqlite.cc Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Dec 30, 2024
View reviewed changes
src/node_sqlite.cc Outdated Show resolved Hide resolved
Patrikoska1
Patrikoska1 reviewed Jan 1, 2025
View reviewed changes
src/node_sqlite.cc Outdated Show resolved Hide resolved
@Patrikoska1 Patrikoska1 mentioned this pull request Jan 1, 2025
Closed
@himself65 himself65 force-pushed the himself65/20241228/fix branch from 3fb606c to a89ce39 Compare January 2, 2025 16:43
@himself65 himself65 changed the title sqlite: support ArrayBuffer and TypedArray in StatementSync sqlite: support TypedArray and DataView in StatementSync Jan 2, 2025
@himself65 himself65 force-pushed the himself65/20241228/fix branch from a89ce39 to 2809f9f Compare January 2, 2025 16:48
@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64297/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64299/

Renegade334
Renegade334 reviewed Jan 2, 2025
View reviewed changes
doc/api/sqlite.md Outdated Show resolved Hide resolved
src/node_sqlite.cc Outdated Show resolved Hide resolved
@himself65 himself65 force-pushed the himself65/20241228/fix branch from 7ad43aa to d85a1e2 Compare January 3, 2025 17:03
@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64309/

aduh95
aduh95 reviewed Jan 3, 2025
View reviewed changes
src/node_sqlite.cc Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Jan 3, 2025
View reviewed changes
src/node_sqlite.cc Outdated Show resolved Hide resolved
@aduh95 aduh95 added semver-minor PRs that contain new features and should be released in the next minor version. experimental Issues and PRs related to experimental features. labels Jan 3, 2025
@himself65 himself65 force-pushed the himself65/20241228/fix branch from dcf8237 to bd5c69b Compare January 3, 2025 18:21
@himself65 himself65 requested a review from aduh95 January 3, 2025 18:24
@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64313/

@himself65 himself65 force-pushed the himself65/20241228/fix branch from bd5c69b to b6b0901 Compare January 3, 2025 19:22
aduh95
aduh95 reviewed Jan 3, 2025
View reviewed changes
doc/api/sqlite.md Outdated Show resolved Hide resolved
@himself65 himself65 force-pushed the himself65/20241228/fix branch from 63de707 to 46c1763 Compare January 4, 2025 06:26
@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64335/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64337/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64340/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64346/

@himself65 himself65 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 08b7d38 into nodejs:main Jan 5, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 08b7d38

@himself65 himself65 deleted the himself65/20241228/fix branch January 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrikoska1 Patrikoska1 Patrikoska1 left review comments

@Renegade334 Renegade334 Renegade334 left review comments

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:sqlite support statement.run with TypedArray
8 participants
@himself65 @nodejs-github-bot @jasnell @anonrig @cjihrig @Renegade334 @aduh95 @Patrikoska1