test: update compiled sqlite tests to match other tests #56446
Merged
+73
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the sqlite compiled tests to be structured like other compiled tests. Refs: nodejs#56347
|
Review requested:
|
nodejs-github-bot
added
build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56446 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.02%
==========================================
Files 657 657
Lines 190741 190741
Branches 36607 36606 -1
==========================================
- Hits 168881 168855 -26
- Misses 15036 15080 +44
+ Partials 6824 6806 -18 |
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jan 3, 2025
cjihrig
added
author ready
aduh95
reviewed
Jan 4, 2025
| "target_name": "sqlite_extension", | ||
| "type": "shared_library", | ||
| "sources": [ "extension.c" ], | ||
| "include_dirs": [ "../../../deps/sqlite" ] |
There was a problem hiding this comment.
Shouldn't we be checking for --shared-sqlite here?
There was a problem hiding this comment.
I'm not sure. We weren't before, but it's possible.
There was a problem hiding this comment.
In any case, the test is skipped when using shared SQLite, so it's not a concern
aduh95
approved these changes
Jan 4, 2025
RafaelGSS
approved these changes
Jan 5, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in d0ff34f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the sqlite compiled tests to be structured like other compiled tests.
Refs: #56347