Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose with merge-ci build #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

joshmoore
Copy link
Member

@joshmoore joshmoore commented Aug 15, 2019

Being used to test ome/omero-web#2

cc: @ome/python

joshmoore added 2 commits May 8, 2019 07:22
Beyond just using make for building a set of paired
omero-web and omero-web-standalone images, this allows
building within a self-contained docker-compose.yml.

see: ome#28
@joshmoore
Copy link
Member Author

Currently failing with:

        location = self._get_python_dir() / "omeroweb"                                                                                  web_1     | OSError: [Errno 13] Permission denied: '/opt/omero/web/venv/lib/python2.7/site-packages/omeroweb/static'

@joshmoore
Copy link
Member Author

Now failing with:

b_1     |   File "/opt/omero/web/venv/lib64/python2.7/os.py", line 157, in makedirs
web_1     |     mkdir(name, mode)
web_1     | OSError: [Errno 13] Permission denied: '/opt/omero/web/venv/lib/python2.7/site-packages/omeroweb/static'
omerowebdocker_web_1 exited with code 1

cc: @ome/python

@manics
Copy link
Member

manics commented Aug 26, 2019

Does setting omero.web.static_root/STATIC_ROOT fix this?
https://github.com/ome/omero-web/blob/d176ac3a833dbec2d55afa3eece6a810820c6922/omeroweb/settings.py#L423-L430

@joshmoore
Copy link
Member Author

What do we want the new value to be? Keep it in lib/python? Under var/? Calculate from OMERODIR?

@joshmoore
Copy link
Member Author

Note: STATIC_ROOT (from docker-compose) does not work but omero.web.static_root does.

@manics
Copy link
Member

manics commented Aug 26, 2019

var sounds good, is the whole /var directory being moved to a read-write location?

@joshmoore
Copy link
Member Author

Eventually, I'd think so.

@joshmoore
Copy link
Member Author

Haven't tested yet, but proposing to push this:

commit dde2cfff9519517265c524e67740c68f66681dee (HEAD -> py2)
Author: jmoore <[email protected]>
Date:   Mon Aug 26 18:30:53 2019 +0200

    Place static files under var/static

diff --git a/omeroweb/settings.py b/omeroweb/settings.py
index 330c64a66..1565d8559 100644
--- a/omeroweb/settings.py
+++ b/omeroweb/settings.py
@@ -424,7 +424,7 @@ CUSTOM_SETTINGS_MAPPINGS = {
           " must end in a slash if set to a non-empty value.")],
     "omero.web.static_root":
         ["STATIC_ROOT",
-         os.path.join(os.path.dirname(__file__), 'static').replace('\\', '/'),
+         os.path.join(OMERO_HOME, 'var', 'static')

@snoopycrimecop snoopycrimecop mentioned this pull request Nov 14, 2019
@joshmoore joshmoore changed the title Py2 docker-compose with merge-ci build Nov 15, 2019
@joshmoore joshmoore mentioned this pull request Nov 20, 2019
@joshmoore
Copy link
Member Author

This will need work with Simon's post-omego world.

@joshmoore joshmoore mentioned this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants