Don't crash when building docs

[koddsson]

I moved the @github/markdown-toolbar-element import into the render function like suggested in https://www.gatsbyjs.com/docs/debugging-html-builds/

Closes github/markdown-toolbar-element#68

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

cc/ @keithamus

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2db9061

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[keithamus]

LGTM

[joshblack]

Responded on the upstream issue, let me know what you think!

Separately, would this run into the same mix-and-match issue described in: #2339 ? Specifically:

This mix of require and import confuses transpilers and occasionally breaks things in unexpected and hard-to-debug ways (for example, see this Slack thread).

[koddsson]

Separately, would this run into the same mix-and-match issue described in: #2339?

I had no issue with the mix of require and import in my testing and I believe that CI should catch any such compiler issues.

[koddsson]

I pushed a commit that utilizes useEffect and dynamic imports so that we can avoid require calls if we want.

Reverted that since nodejs/jest seems to crash with a dynamic import.

[joshblack]

@koddsson sorry about the dynamic import stuff 😞 Seems like the same issue that @iansan5653 ran into.

For the mix-and-match, this would end up being a bundler behavior, right? If I understand right, require() is undefined in an ESM scope.

Also wanted to check-in with the deploy preview, it seems like the build is failing with this error:

[koddsson]

Also wanted to check-in with the deploy preview, it seems like the build is failing with this error:

I don't see this anywhere. Do you have a link to this UI?

[joshblack]

@koddsson let me know if this works! https://github.com/primer/react/actions/runs/3144532666/jobs/5110661581

I think it's showing up for the Deploy (fork) workflow

[koddsson]

I annoyingly can't reproduce the deploy error locally. Any ideas? Can you reproduce it?

[koddsson]

I annoyingly can't reproduce the deploy error locally. Any ideas? Can you reproduce it?

Seems like this was a issue with me not having push access to this repo. Seems to be running green now 👍🏻

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.