Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when building docs #2379

Closed
wants to merge 8 commits into from
Closed

Don't crash when building docs #2379

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b865f12
Don't crash when building docs
koddsson Sep 27, 2022
c7f48b6
Merge branch 'move-markdown-toolbar-element-into-uncodnitional-render…
koddsson Sep 27, 2022
25ec829
Remove import again after bad merge
koddsson Sep 27, 2022
4247039
Replace require call with a dynamic import
koddsson Sep 27, 2022
2c41f8b
Disable prettier rule
koddsson Sep 27, 2022
97947fa
Revert "Replace require call with a dynamic import"
koddsson Sep 28, 2022
3c70835
Wrap `@github/markdown-toolbar-element` require in `useEffect`
koddsson Sep 30, 2022
2db9061
Don't evaluate on every render
Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/drafts/MarkdownEditor/_FormattingTools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React, {forwardRef, useImperativeHandle, useRef} from 'react'
import '@github/markdown-toolbar-element'
import React, {forwardRef, useImperativeHandle, useRef, useEffect} from 'react'

export type FormattingTools = {
header: () => void
Expand Down Expand Up @@ -49,6 +48,10 @@ export const FormattingTools = forwardRef<FormattingTools, {forInputId: string}>
reference: () => referenceRef.current?.click()
}))

useEffect(() => {
require('@github/markdown-toolbar-element')
}, [])

return (
<markdown-toolbar for={forInputId} style={{display: 'none'}}>
<md-header ref={headerRef} />
Expand Down