-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnableExif #421
base: main
Are you sure you want to change the base?
EnableExif #421
Conversation
@jywarren just wanted to follow up here!! Because I think I fixed the functionality and we've been needing to do that for a while. but don't know where to get an image with location data? |
Aha! Good question. Here's some! https://publiclab.org/notes/patcoyle/03-23-2015/using-the-mapknitter-2-image-placement-using-geotagged-images You can download them and use them to test this out, and compare to Pat's test map! |
Hi!! Just noting i've consolidated the latest information about this feature in this new issue: #1024 |
Fixes #169 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
=========
changes:
fullResolutionSrc
option is now used to check for EXIF metadata if provided, instead of automaticallyimg.getElement()
, becauseimg.getElement()
may typically be a compressed version with no metadata on it.EnableExif
should now be working, but need to test with an image with gps data (neitherexample.jpg
orlarge.jpg
have GPS data. -example.jpg
has no EXIF metadata at all andlarge.jpg
has some but not GPS)pending:
fullResolutionSrc
option docsoverlay._corners
tooverlay.setCorners()
=========