-
-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update translations #18849
chore: Update translations #18849
Conversation
Summoning @sombraguerrero, because I saw that you approved these after "Load3r" suggested them (with one exception, after undoing that translated string key mistake). At least one of these strings having changed in #18839, and is now essentially reverted. I think it would be great to avoid any sort of back-and-forth between the variants in the future. |
39c3d22
to
a8e1345
Compare
I acknowledge my timing on that one sucked. Just haven't had a to of time lately, sorry. |
Yeah no worries - I mainly wanted confirmation about the rest of the strings, that these are indeed the better ones, and are here to stay. 😊 |
bcd1646
to
e2824ef
Compare
230ded4
to
b4a0465
Compare
1227e44
to
2663c8c
Compare
player-runtime-flash = Flash Player | ||
player-runtime-flash = Lecteur Flash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be translated? Adobe doesn't translate runtime names in their docs.
I see that it's translated in Ruffle in some languages, in some it isn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
I'm also unsure about the change related to the letterbox setting: while the translation itself is correct, the word "letterbox" is usually not translated (eg. https://fr.wikipedia.org/wiki/Letterbox).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted this, also updated translations for other languages where this shouldn't be translated
ec717ed
to
55b31da
Compare
8bb4ee8
to
cc1782a
Compare
@@ -28,5 +28,5 @@ gamemode = GameMode | |||
gamemode-tooltip = | |||
GameMode aplica temporalmente un set de optimizaciones a tu computadora y/o a Ruffle. | |||
Ruffle solicita GameMode solo cuando se está reproduciendo una película. | |||
gamemode-default = Por defecto | |||
gamemode-default-tooltip = GameMode solo será habilitado cuando la preferencia de poder esté en alto. | |||
gamemode-default = Predeterminado |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this is better, @kjarosh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, it's not obviously wrong for me, so I trusted the translator
@@ -3,6 +3,7 @@ player-settings = Spieler-Einstellungen | |||
movie-parameters = Filmparameter | |||
custom-base-url = Benutzerdefinierte Base-URL | |||
spoof-swf-url = Gefälschte SWF-URL | |||
referer-url = Referenz URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm: https://de.wikipedia.org/wiki/Referrer
Which one do you think is more appropriate, @evilpie?
cc1782a
to
d7ebb20
Compare
@torokati44 I think we should merge this PR and leave remaining concerns as comments/issues on Crowdin. They are not blocking and some translations have been waiting for over 27 days as of now. What's your opinion on this? |
d7ebb20
to
6a166ce
Compare
New Crowdin pull request with translations 🎉