Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update translations #18849

Merged
merged 1 commit into from
Dec 30, 2024
Merged

chore: Update translations #18849

merged 1 commit into from
Dec 30, 2024

Conversation

RuffleBuild
Copy link
Collaborator

New Crowdin pull request with translations 🎉

@RuffleBuild RuffleBuild added T-chore Type: Chore (like updating a dependency, it's gotta be done) A-i18n Area: Internationalization & Localization labels Dec 3, 2024
desktop/assets/texts/es-ES/preferences_dialog.ftl Outdated Show resolved Hide resolved
@torokati44
Copy link
Member

Summoning @sombraguerrero, because I saw that you approved these after "Load3r" suggested them (with one exception, after undoing that translated string key mistake).

At least one of these strings having changed in #18839, and is now essentially reverted. I think it would be great to avoid any sort of back-and-forth between the variants in the future.

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch from 39c3d22 to a8e1345 Compare December 4, 2024 00:03
@torokati44 torokati44 dismissed their stale review December 4, 2024 00:04

Undid the problematic translation.

@sombraguerrero
Copy link
Contributor

I acknowledge my timing on that one sucked. Just haven't had a to of time lately, sorry.

@torokati44
Copy link
Member

torokati44 commented Dec 4, 2024

Yeah no worries - I mainly wanted confirmation about the rest of the strings, that these are indeed the better ones, and are here to stay. 😊

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 3 times, most recently from bcd1646 to e2824ef Compare December 6, 2024 21:07
@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 7 times, most recently from 230ded4 to b4a0465 Compare December 13, 2024 21:09
@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 2 times, most recently from 1227e44 to 2663c8c Compare December 15, 2024 21:06
player-runtime-flash = Flash Player
player-runtime-flash = Lecteur Flash
Copy link
Member

@kjarosh kjarosh Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be translated? Adobe doesn't translate runtime names in their docs.

I see that it's translated in Ruffle in some languages, in some it isn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.☺️I did almost all of the French translation, and I agree that this shouldn't be translated in this context.

I'm also unsure about the change related to the letterbox setting: while the translation itself is correct, the word "letterbox" is usually not translated (eg. https://fr.wikipedia.org/wiki/Letterbox).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this, also updated translations for other languages where this shouldn't be translated

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 7 times, most recently from ec717ed to 55b31da Compare December 22, 2024 21:06
@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 8 times, most recently from 8bb4ee8 to cc1782a Compare December 29, 2024 22:42
@@ -28,5 +28,5 @@ gamemode = GameMode
gamemode-tooltip =
GameMode aplica temporalmente un set de optimizaciones a tu computadora y/o a Ruffle.
Ruffle solicita GameMode solo cuando se está reproduciendo una película.
gamemode-default = Por defecto
gamemode-default-tooltip = GameMode solo será habilitado cuando la preferencia de poder esté en alto.
gamemode-default = Predeterminado
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this is better, @kjarosh?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, it's not obviously wrong for me, so I trusted the translator

@@ -3,6 +3,7 @@ player-settings = Spieler-Einstellungen
movie-parameters = Filmparameter
custom-base-url = Benutzerdefinierte Base-URL
spoof-swf-url = Gefälschte SWF-URL
referer-url = Referenz URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm: https://de.wikipedia.org/wiki/Referrer

Which one do you think is more appropriate, @evilpie?

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch from cc1782a to d7ebb20 Compare December 30, 2024 00:27
@kjarosh
Copy link
Member

kjarosh commented Dec 30, 2024

@torokati44 I think we should merge this PR and leave remaining concerns as comments/issues on Crowdin. They are not blocking and some translations have been waiting for over 27 days as of now. What's your opinion on this?

@torokati44 torokati44 force-pushed the l10n_crowdin_translations branch from d7ebb20 to 6a166ce Compare December 30, 2024 14:46
@torokati44 torokati44 enabled auto-merge (rebase) December 30, 2024 14:46
@torokati44 torokati44 merged commit 390e700 into master Dec 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-i18n Area: Internationalization & Localization T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants