Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apollo federation spec compliance tool in CI #287

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

oskargotte
Copy link
Contributor

@oskargotte oskargotte commented Nov 19, 2023

Adds a copy of the product subgraph implemented in apollo-federation-subgraph-compatibility repo.

Also includes a Github action to run on each pull request which checks compatibility against Apollo Federation Subgraph Specification and posts the results to the PR.

Targets #215

# Turn on debug mode with extra log info
debug: false
# Github Token / PAT for submitting PR comments
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GITHUB_TOKEN is used to enable the capability to post test results as a comment in the PR. This, however, would need the action to be configured with a Github Token that has PR write permissions. See Apollo Federation spec compliance tools for details about the Github action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GITHUB_TOKEN has write permissions. Let's see if that works.

Screenshot 2024-01-24 at 14 18 24

@yanns
Copy link
Contributor

yanns commented Nov 21, 2023

Thanks a lot! I'll have a look later.

@oskargotte
Copy link
Contributor Author

Thanks a lot! I'll have a look later.

Sure! And it's just a proposal. Feel free to reject or suggest any improvements 😃

@yanns yanns added this pull request to the merge queue Jan 24, 2024
Merged via the queue into sangria-graphql:main with commit 7a1e155 Jan 24, 2024
4 checks passed
@yanns
Copy link
Contributor

yanns commented Jan 24, 2024

Thanks a lot for your contribution!

Your help is very valuable. I've allowed myself to add you to https://github.com/orgs/sangria-graphql/teams/contributors so that you can have more permissions to contribute if you want. If you disagree, just tell me, and I'll remove you.

@oskargotte
Copy link
Contributor Author

Thanks a lot for your contribution!

Your help is very valuable. I've allowed myself to add you to https://github.com/orgs/sangria-graphql/teams/contributors so that you can have more permissions to contribute if you want. If you disagree, just tell me, and I'll remove you.

Thanks. I'd like to help out if possible. Let's see how much time I can spend on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants