Edit arguments given to run new upgraded subctl #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaanki
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr970/Jaanki/upgrade_arg_slicing |
Jaanki
added
the
backport
skitt
approved these changes
Oct 9, 2023
tpantelis
approved these changes
Oct 9, 2023
sridhargaddam
approved these changes
Oct 10, 2023
Jaanki
force-pushed
the
upgrade_arg_slicing
branch
from
de1a1db to
616acf8
Compare
Jaanki
force-pushed
the
upgrade_arg_slicing
branch
from
616acf8 to
3379d94
Compare
|
Removing |
os.Args[1:] dropped prefix `subctl` so when upgrade is run using upgraded subctl, `upgrade` is considered as the new parent command and hencce complains about the `--to-version` validity. This PR drops the arg slicing. Closes: submariner-io#962 Signed-off-by: Janki Chhatbar <[email protected]>
Jaanki
force-pushed
the
upgrade_arg_slicing
branch
from
3379d94 to
823fd20
Compare
|
🤖 Closed branches: [z_pr970/Jaanki/upgrade_arg_slicing] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.Args[1:] dropped prefix
subctlso when upgrade is run using upgraded subctl,upgradeis considered as the new parent command and hencce complains about the--to-versionvalidity.This PR drops the arg slicing.
Closes: #962