Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit arguments given to run new upgraded subctl #970

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Edit arguments given to run new upgraded subctl #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/upgrade-subctl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ jobs:
- name: Build new subctl
run: make cmd/bin/subctl

- name: Run upgrade command
run: cmd/bin/subctl upgrade
- name: Run upgrade command and check versions after upgrade
run: |
export KUBECONFIG=$(find $(git rev-parse --show-toplevel)/output/kubeconfigs/ -type f -printf %p:)
cmd/bin/subctl upgrade
cmd/bin/subctl version && cmd/bin/subctl show versions

- name: Run e2e tests
run: make e2e
Expand Down
2 changes: 1 addition & 1 deletion cmd/subctl/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func upgrade(_ *cobra.Command, _ []string) {
// Step 2a: subctl was upgraded, so run it instead of continuing
cmd := exec.Cmd{
Path: command,
Args: os.Args[1:],
Args: os.Args,
Stdin: os.Stdin,
Stdout: os.Stdout,
Stderr: os.Stderr,
Expand Down
Loading