Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release guidance for Valkey #94

Merged
merged 10 commits into from
Jun 21, 2024
Merged

Conversation

madolson
Copy link
Member

A fairly extensive rewrite of the Valkey release and versioning documentation from our docs. Generally made two significant changes.

  1. Made much clearer guidance around semantic versioning and how we follow it.
  2. Made more explicit the support model for how long we maintain a release.

@valkey-io/core-team and @valkey-io/contributors, PTAL.

topics/releases.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

Shall we continue using only even numbers for minor versions? If yes, shall we mention this anywhere?

topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
@madolson
Copy link
Member Author

Shall we continue using only even numbers for minor versions? If yes, shall we mention this anywhere?

Ah yes! I'll incorporate that.

Signed-off-by: Madelyn Olson <[email protected]>
topics/releases.md Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
@madolson madolson requested review from PingXie and zuiderkwast June 18, 2024 05:02
Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have just one last clarification question to validate my understanding.

wordlist Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
topics/releases.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. (Just some nits.)

Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

madolson and others added 4 commits June 20, 2024 19:45
@madolson madolson merged commit c8644e8 into valkey-io:main Jun 21, 2024
2 checks passed
New features and configuration directives may be added, or default values
changed, as long as these don’t carry significant impacts or introduce
operations-related issues.
**NOTE:** Minor releases may include new commands and data types that can introduce incompatibility between servers in the cluster, but users need to opt-in to these features to cause this type of incompatibility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an issue. Generally, when we introduce a new data type, the rdb_version is also updated accordingly. So, even if users haven't used the new data type, the newer version nodes in the cluster would already be utilizing the updated rdb_version. In this scenario, if data is migrated from a newer version to an older version, errors would occur.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If we want to be forward-compatible, which I think is a good idea, we need to support writing RDB in an old version and a new version. We only need to be forward compatible one version, I think.

HLD: The first time a new datatype is used, we set a global flag. When we write the RDB, we check the flag. If the flag is set, we use the new RDB version. If the flag is not set, we use the older RDB version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soloestoy the long term solution is AOF without RDB? valkey-io/valkey#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants