-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release guidance for Valkey #94
Conversation
Signed-off-by: Madelyn Olson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
Shall we continue using only even numbers for minor versions? If yes, shall we mention this anywhere?
Ah yes! I'll incorporate that. |
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have just one last clarification question to validate my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. (Just some nits.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Madelyn Olson <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
New features and configuration directives may be added, or default values | ||
changed, as long as these don’t carry significant impacts or introduce | ||
operations-related issues. | ||
**NOTE:** Minor releases may include new commands and data types that can introduce incompatibility between servers in the cluster, but users need to opt-in to these features to cause this type of incompatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an issue. Generally, when we introduce a new data type, the rdb_version
is also updated accordingly. So, even if users haven't used the new data type, the newer version nodes in the cluster would already be utilizing the updated rdb_version
. In this scenario, if data is migrated from a newer version to an older version, errors would occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. If we want to be forward-compatible, which I think is a good idea, we need to support writing RDB in an old version and a new version. We only need to be forward compatible one version, I think.
HLD: The first time a new datatype is used, we set a global flag. When we write the RDB, we check the flag. If the flag is set, we use the new RDB version. If the flag is not set, we use the older RDB version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soloestoy the long term solution is AOF without RDB? valkey-io/valkey#59
A fairly extensive rewrite of the Valkey release and versioning documentation from our docs. Generally made two significant changes.
@valkey-io/core-team and @valkey-io/contributors, PTAL.