Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release guidance for Valkey #94
Update release guidance for Valkey #94
Changes from 1 commit
829f029
9deb7c7
5352f3a
19e4ca3
58519e0
88e89b9
2b2e67b
7c095e7
5b3d54a
ea1ac8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an issue. Generally, when we introduce a new data type, the
rdb_version
is also updated accordingly. So, even if users haven't used the new data type, the newer version nodes in the cluster would already be utilizing the updatedrdb_version
. In this scenario, if data is migrated from a newer version to an older version, errors would occur.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. If we want to be forward-compatible, which I think is a good idea, we need to support writing RDB in an old version and a new version. We only need to be forward compatible one version, I think.
HLD: The first time a new datatype is used, we set a global flag. When we write the RDB, we check the flag. If the flag is set, we use the new RDB version. If the flag is not set, we use the older RDB version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soloestoy the long term solution is AOF without RDB? valkey-io/valkey#59