Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: fix flaky test #2657

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Node: fix flaky test #2657

merged 1 commit into from
Dec 10, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Nov 9, 2024 •
edited
Loading

Issue link

https://github.com/valkey-io/valkey-glide/actions/runs/11737024037/job/32697212681#step:5:496
https://github.com/valkey-io/valkey-glide/actions/runs/11737024037/job/32697211683#step:5:497

  1. Dump for some values can be successfully represented by an UTF-8 string
  2. Different errors could be produced while converting incompatible byte[] into a string
  3. Fix for npm run test - it was ignoring rest of the command line (e.g. npm run test -- --testNamePattern="dump and restore transactions" --standalone-endpoints=localhost:6379)
  4. This PR also includes backport for Node: Fix modules CI #2768 to main

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Yury-Fridlyand Yury-Fridlyand added node Node.js wrapper testing Everything about testing labels Nov 9, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner November 9, 2024 07:41
avifenesh
avifenesh reviewed Nov 9, 2024
View reviewed changes
node/package.json Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand added the Flaky-tests Flaky-tests label Nov 25, 2024
@Yury-Fridlyand Yury-Fridlyand changed the base branch from release-1.2 to main December 6, 2024 19:04
@Yury-Fridlyand
fix tests
863b777 
Signed-off-by: Yury-Fridlyand <[email protected]>
@yipin-chen yipin-chen merged commit 3542b2a into valkey-io:main Dec 10, 2024
19 checks passed
@yipin-chen yipin-chen deleted the node/yuryf-fix-IT branch December 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@jamesx-improving jamesx-improving jamesx-improving approved these changes

@avifenesh avifenesh Awaiting requested review from avifenesh

Assignees
No one assigned
Labels
Flaky-tests Flaky-tests node Node.js wrapper testing Everything about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yury-Fridlyand @avifenesh @jamesx-improving @yipin-chen