-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert pull request target in favour of pull request #167
Conversation
Warning Rate Limit Exceeded@alichherawalla has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 42 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent project update refined the documentation with a focus on precision. It rectified a newline issue in the license section of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)
Line range hint
24-24
: Consider using an intermediate environment variable for branch name extraction to mitigate potential security risks.- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }} + env: + BRANCH_NAME: ${{ github.event.pull_request.head.ref }} + run: echo ::set-output name=branch::$BRANCH_NAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)
Line range hint
22-22
: Consider mitigating potential security risks by using an intermediate environment variable for branch names.- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }} + env: + BRANCH_NAME: ${{ github.event.pull_request.head.ref }} + run: echo ::set-output name=branch::$BRANCH_NAMEEnsure to wrap the environment variable in double quotes when used in shell scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)
Line range hint
1-1
: Ensure secure handling ofgithub
context data inrun:
steps. Use intermediate environment variables to mitigate injection risks.# Example fix for a hypothetical `run:` step using `github` context data - run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }} + env: + BRANCH_NAME: ${{ github.event.pull_request.head.ref }} + run: echo ::set-output name=branch::$BRANCH_NAME
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)
Line range hint
22-22
: Consider using an intermediate environment variable for branch name extraction to enhance security.- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }} + env: + BRANCH_NAME: ${{ github.event.pull_request.head.ref }} + run: echo ::set-output name=branch::$BRANCH_NAMEEnsure to wrap the environment variable in double quotes when using it in the script.
Ticket Link
Related Links
Description
Sonar pull request analysis no longer work because we're using pull_request_targets. This prevents the sonarbot from commenting and analysis being provided for the new code
Steps to Reproduce / Test
Request
Response
Summary by CodeRabbit