Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert pull request target in favour of pull request #167

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Conversation

alichherawalla
Copy link
Contributor

@alichherawalla alichherawalla commented Apr 9, 2024

Ticket Link


Related Links


Description


Sonar pull request analysis no longer work because we're using pull_request_targets. This prevents the sonarbot from commenting and analysis being provided for the new code

Steps to Reproduce / Test


Request


Response


Summary by CodeRabbit

  • Documentation
    • Updated license section in the README for clarity.
  • Chores
    • Removed sensitive environment variable from SonarQube workflows.

Copy link

coderabbitai bot commented Apr 9, 2024

Warning

Rate Limit Exceeded

@alichherawalla has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 42 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between b7f5eb3 and b22064d.

Walkthrough

The recent project update refined the documentation with a focus on precision. It rectified a newline issue in the license section of the README.MD file and removed the GITHUB_TOKEN from the SonarQube steps in .github/workflows/go-template-ci.yml. These changes, though small, uphold document integrity and security practices.

Changes

File Change Summary
README.MD Fixed newline issue in license section
.github/workflows/go-template-ci.yml Removed GITHUB_TOKEN from SonarQube steps

🐇✨
In the realm of code, where rabbits hop,
A tiny change makes a big leap nonstop.
With a newline fixed, all becomes clear,
A document now perfect, let's cheer!
So hop along, dear friends, with glee,
For in our world, the details set us free.
🌟📜✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)

Line range hint 24-24: Consider using an intermediate environment variable for branch name extraction to mitigate potential security risks.

- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }}
+ env:
+   BRANCH_NAME: ${{ github.event.pull_request.head.ref }}
+ run: echo ::set-output name=branch::$BRANCH_NAME

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)

Line range hint 22-22: Consider mitigating potential security risks by using an intermediate environment variable for branch names.

- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }}
+ env:
+   BRANCH_NAME: ${{ github.event.pull_request.head.ref }}
+ run: echo ::set-output name=branch::$BRANCH_NAME

Ensure to wrap the environment variable in double quotes when used in shell scripts.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)

Line range hint 1-1: Ensure secure handling of github context data in run: steps. Use intermediate environment variables to mitigate injection risks.

# Example fix for a hypothetical `run:` step using `github` context data
- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }}
+ env:
+   BRANCH_NAME: ${{ github.event.pull_request.head.ref }}
+ run: echo ::set-output name=branch::$BRANCH_NAME

This comment has been minimized.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
.github/workflows/go-template-ci.yml (1)

Line range hint 22-22: Consider using an intermediate environment variable for branch name extraction to enhance security.

- run: echo ::set-output name=branch::${{ github.event.pull_request.head.ref }}
+ env:
+   BRANCH_NAME: ${{ github.event.pull_request.head.ref }}
+ run: echo ::set-output name=branch::$BRANCH_NAME

Ensure to wrap the environment variable in double quotes when using it in the script.

Copy link

sonarqube-ws bot commented Apr 9, 2024

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (95.70% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: wednesday-solutions_go-template_AY4Ik1IUB2n8RRmGoUiD

View in SonarQube

@alichherawalla alichherawalla changed the title Update README.MD revert pull request target in favour of pull request Apr 9, 2024
@alichherawalla alichherawalla merged commit 9e3bdf7 into master Apr 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant