Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert pull request target in favour of pull request #167

Merged
merged 6 commits into from
Apr 9, 2024
Merged

revert pull request target in favour of pull request #167

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b5dd150
Update README.MD
alichherawalla Apr 9, 2024
f0d8e12
remove GITHUB_TOKEN since its not needed
alichherawalla Apr 9, 2024
5ea609d
run CI only on pull request
alichherawalla Apr 9, 2024
8ee912a
remove quality gate
alichherawalla Apr 9, 2024
b7f5eb3
revert back to pull_request
alichherawalla Apr 9, 2024
b22064d
add sonar quality gate back
alichherawalla Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/go-template-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ on:
pull_request_target:
branches:
- master
push:
branches:
- master

jobs:
lint-test-build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -45,13 +43,11 @@ jobs:
- name: SonarQube Scan
uses: sonarsource/sonarqube-scan-action@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
- uses: sonarsource/sonarqube-quality-gate-action@master
timeout-minutes: 5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
# testing image url
Expand Down
2 changes: 1 addition & 1 deletion README.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,4 +358,4 @@ using [graphql-test](https://www.npmjs.com/package/graphql-testkit)

## License

Go Template is licensed under the MIT license. Check the [LICENSE](LICENSE) file for details.
Go Template is licensed under the MIT license. Check the [LICENSE](LICENSE) file for details.
Loading