Interactive Mode and Renaming APIs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng everything before prompt.
…hem. libyt only borrows defined names (everything about char*) from simulation, and does not make a copy. I'm not sure do we really need to make a copy, since everything will be inside python, and if we really don't want to care about the lifetime of these char *, we can always look up inside python. But I think it is unnecessary to make a copy or look it up inside python, since these are variables already defined in simulation. If not, then we can always assign it to a const char *.
…ws their names. libyt only borrows defined names (everything about char*) from simulation, and does not make a copy. I'm not sure do we really need to make a copy, since everything will be inside python, and if we really don't want to care about the lifetime of these char *, we can always look up inside python. But I think it is unnecessary to make a copy or look it up inside python, since these are variables already defined in simulation. If not, then we can always assign it to a const char *.
…t branch in cindytsai/yt. Will PR to yt asap.
cindytsai
added
doc
33 tasks
Logical bug: interactive mode will stop even if that function is set to idle. Fixed version: interactive mode only stops when function that set to run has error, or stop file is detected.
This commit is only for my own reference when using PyEval_EvalCode. My guessing : It looks like Python's error buffer should be cleared when running PyEval_EvalCode. Otherwise, it leads to segmentation fault (11), and you won't have any idea what went wrong. They should have mentioned this in their doc though.
Make yt_run_Function* and this method running python function in the same way.
…ding. operator+= return reference in std::string.
|
Finally!! 🎇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Interactive Mode and Renaming APIs
Interactive Mode
Related Issue:
Main Feature
Renaming APIs and Changing Data Types
Naming
ytsince currently,libytis specific for passing AMR grid data structure used insideyt.Data and Their Lifetime
libytonly borrows labels and names (data typechar*) from simulation, and it does not make a copy. We should make sure that the pointers (specificallychar*) passed in have the lifetime that covers the whole in situ process.doc.