Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruffing it #806

Merged
merged 43 commits into from
Oct 30, 2023
Merged

Ruffing it #806

merged 43 commits into from
Oct 30, 2023

Conversation

andersk
Copy link
Member

@andersk andersk commented Oct 30, 2023

No description provided.

andersk added 11 commits October 28, 2023 16:17
@andersk
ruff: Fix RSE102 Unnecessary parentheses on raised exception.
88ab78e 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix G010 Logging statement uses warn instead of warning.
1ccb5db 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix G001 Logging statement uses str.format.
e537bbe 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix G002 Logging statement uses %.
02e0555 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix G003 Logging statement uses +.
d85ace8 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix G004 Logging statement uses f-string.
6b2861c 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix TRY401 Redundant exception object included in `logging.exce…
235f92a 
…ption` call.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix EXE001 Shebang is present but file is not executable.
ca3e5a2 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix EXE002 The file is executable but no shebang is present.
353c2de 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix C400 Unnecessary generator (rewrite as a list comprehensi…
774edb4 
…on).

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix C417 Unnecessary map usage (rewrite using a generator exp…
13e860e 
…ression).

Signed-off-by: Anders Kaseorg <[email protected]>
andersk added 12 commits October 29, 2023 18:17
@andersk
ruff: Fix SIM101 Multiple isinstance calls for val, merge into a …
c75f5b3 
…single call.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM102 Use a single if statement instead of nested if s…
58a3026 
…tatements.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM103 Return the condition directly.
6a4ad88 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM105 Use contextlib.suppress instead of try-except-…
2aa36f9 
…`pass`.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM108 Use ternary operator instead of if-else-block.
b009dcd 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM114 Combine if branches using logical or operator.
6a37290 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM118 Use key in dict instead of key in dict.keys().
93156d9 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM201 Use … != … instead of not … == ….
8b5b395 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix SIM300 Yoda conditions are discouraged.
008efed 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PIE808 Unnecessary start argument in range.
ad9c085 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PIE810 Call startswith once with a tuple.
7aeb8f2 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix B009 Do not call getattr with a constant attribute value.
272c63b 
Signed-off-by: Anders Kaseorg <[email protected]>
andersk added 14 commits October 30, 2023 11:44
@andersk
ruff: Fix N818 Exception name should be named with an Error suffix.
54263e5 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLR1711 Useless return statement at end of function.
192024e 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLR1714 Consider merging multiple comparisons.
93bb7eb 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLR1722 Use sys.exit() instead of exit.
5c934e5 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLR5501 Use elif instead of else then if, to reduce i…
11ea5c7 
…ndentation.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLW0602 Using global but no assignment is done.
e18d35d 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLW0603 Using the global statement to update is discouraged.
18805ac 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix PLW2901 for loop variable overwritten by assignment target.
12e63f4 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix RUF005 Consider unpacking instead of concatenation.
610683e 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix RUF015 Prefer next(iter(…)) over single element slice.
347490c 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix B005 Using .strip() with multi-character strings is misle…
32e0520 
…ading.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix B006 Do not use mutable data structures for argument defaults.
69aaf69 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix B007 Loop control variable not used within loop body.
03d132e 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk
ruff: Fix B018 Found useless expression.
d546a39 
Signed-off-by: Anders Kaseorg <[email protected]>
@andersk andersk merged commit 5199c14 into zulip:main Oct 30, 2023
13 checks passed
@andersk andersk deleted the ruff branch October 30, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersk @zulipbot