Code

Ruffing it#806

Code

Merged

andersk merged 43 commits intozulip:mainzulip/python-zulip-api:mainfrom andersk:ruffandersk/python-zulip-api:ruffCopy head branch name to clipboardOct 30, 2023

+701-835

Commits

Commits on Oct 28, 2023

• ruff: Fix RSE102 Unnecessary parentheses on raised exception.

  Show description for 88ab78e
  andersk

  committed
  88ab78e

• ruff: Fix G010 Logging statement uses warn instead of warning.

  Show description for 1ccb5db
  andersk

  committed
  1ccb5db

• ruff: Fix G001 Logging statement uses str.format.

  Show description for e537bbe
  andersk

  committed
  e537bbe

• ruff: Fix G002 Logging statement uses %.

  Show description for 02e0555
  andersk

  committed
  02e0555

• ruff: Fix G003 Logging statement uses +.

  Show description for d85ace8
  andersk

  committed
  d85ace8

• ruff: Fix G004 Logging statement uses f-string.

  Show description for 6b2861c
  andersk

  committed
  6b2861c

• ruff: Fix TRY401 Redundant exception object included in logging.exception call.

  Show description for 235f92a
  andersk

  committed
  235f92a

Commits on Oct 29, 2023

• ruff: Fix EXE001 Shebang is present but file is not executable.

  Show description for ca3e5a2
  andersk

  committed
  ca3e5a2

• ruff: Fix EXE002 The file is executable but no shebang is present.

  Show description for 353c2de
  andersk

  committed
  353c2de

Commits on Oct 30, 2023

• ruff: Fix C400 Unnecessary generator (rewrite as a list comprehension).

  Show description for 774edb4
  andersk

  committed
  774edb4

• ruff: Fix C417 Unnecessary map usage (rewrite using a generator expression).

  Show description for 13e860e
  andersk

  committed
  13e860e

• ruff: Fix SIM101 Multiple isinstance calls for val, merge into a single call.

  Show description for c75f5b3
  andersk

  committed
  c75f5b3

• ruff: Fix SIM102 Use a single if statement instead of nested if statements.

  Show description for 58a3026
  andersk

  committed
  58a3026

• ruff: Fix SIM103 Return the condition directly.

  Show description for 6a4ad88
  andersk

  committed
  6a4ad88

• ruff: Fix SIM105 Use contextlib.suppress instead of try-except-pass.

  Show description for 2aa36f9
  andersk

  committed
  2aa36f9

• ruff: Fix SIM108 Use ternary operator instead of if-else-block.

  Show description for b009dcd
  andersk

  committed
  b009dcd

• ruff: Fix SIM114 Combine if branches using logical or operator.

  Show description for 6a37290
  andersk

  committed
  6a37290

• ruff: Fix SIM118 Use key in dict instead of key in dict.keys().

  Show description for 93156d9
  andersk

  committed
  93156d9

• ruff: Fix SIM201 Use … != … instead of not … == ….

  Show description for 8b5b395
  andersk

  committed
  8b5b395

• ruff: Fix SIM300 Yoda conditions are discouraged.

  Show description for 008efed
  andersk

  committed
  008efed

• ruff: Fix PIE808 Unnecessary start argument in range.

  Show description for ad9c085
  andersk

  committed
  ad9c085

• ruff: Fix PIE810 Call startswith once with a tuple.

  Show description for 7aeb8f2
  andersk

  committed
  7aeb8f2

• ruff: Fix B009 Do not call getattr with a constant attribute value.

  Show description for 272c63b
  andersk

  committed
  272c63b

• ruff: Fix N801 Class name should use CapWords convention.

  Show description for 2c4e706
  andersk

  committed
  2c4e706

• ruff: Fix N802 Function name should be lowercase.

  Show description for d5ad330
  andersk

  committed
  d5ad330

• ruff: Fix N803 Argument name should be lowercase.

  Show description for 5e708e3
  andersk

  committed
  5e708e3

• ruff: Fix N806 Variable in function should be lowercase.

  Show description for 87e7d31
  andersk

  committed
  87e7d31

• ruff: Fix N816 Variable in global scope should not be mixedCase.

  Show description for a8aec78
  andersk

  committed
  a8aec78

• ruff: Fix N818 Exception name should be named with an Error suffix.

  Show description for 54263e5
  andersk

  committed
  54263e5

• ruff: Fix PLR1711 Useless return statement at end of function.

  Show description for 192024e
  andersk

  committed
  192024e

• ruff: Fix PLR1714 Consider merging multiple comparisons.

  Show description for 93bb7eb
  andersk

  committed
  93bb7eb

• ruff: Fix PLR1722 Use sys.exit() instead of exit.

  Show description for 5c934e5
  andersk

  committed
  5c934e5

• ruff: Fix PLR5501 Use elif instead of else then if, to reduce indentation.

  Show description for 11ea5c7
  andersk

  committed
  11ea5c7

• ruff: Fix PLW0602 Using global but no assignment is done.

  Show description for e18d35d
  andersk

  committed
  e18d35d

• ruff: Fix PLW0603 Using the global statement to update is discouraged.

  Show description for 18805ac
  andersk

  committed
  18805ac

• ruff: Fix PLW2901 for loop variable overwritten by assignment target.

  Show description for 12e63f4
  andersk

  committed
  12e63f4

• ruff: Fix RUF005 Consider unpacking instead of concatenation.

  Show description for 610683e
  andersk

  committed
  610683e

• ruff: Fix RUF015 Prefer next(iter(…)) over single element slice.

  Show description for 347490c
  andersk

  committed
  347490c

• ruff: Fix B005 Using .strip() with multi-character strings is misleading.

  Show description for 32e0520
  andersk

  committed
  32e0520

• ruff: Fix B006 Do not use mutable data structures for argument defaults.

  Show description for 69aaf69
  andersk

  committed
  69aaf69

• ruff: Fix B007 Loop control variable not used within loop body.

  Show description for 03d132e
  andersk

  committed
  03d132e

• ruff: Fix B018 Found useless expression.

  Show description for d546a39
  andersk

  committed
  d546a39

• ruff: Fix PERF401 Use a list comprehension to create a transformed list.

  Show description for 5199c14
  andersk

  committed
  5199c14